linux-kernel - Re: [PATCH] kernel: module: strncpy issue, using strlcpy instead of strncpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51637441.2090006@asianux.com>
Date:	Tue, 09 Apr 2013 09:52:01 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	Rusty Russell <rusty@...tcorp.com.au>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kernel: module: strncpy issue, using strlcpy instead
 of strncpy

On 2013年04月08日 21:45, Rusty Russell wrote:
>> >
>> > and for this patch, is it suitable to send patch v2 ?
> Yes, that's fine.
> 

  thanks, I will send patch v2 (the subject need delete "strncpy issue")


>>> >> However, kallsyms_lookup also calls kallsyms_expand_symbol, which
>>> >> doesn't stop at KSYM_NAME_LEN, so if a name was longer than that we'd
>>> >> have a real bug.
>>> >> 
>>> >> Would you like to take a look at that, too?
>>> >> 
>> >
>> >   it looks like a bug.  for me, I prefer to give length check for it.
>> >
>> >   but I am sorry, now, I can not be sure whether it is really a bug.
> It really is.  We don't export any symbols > 128 characters, but if we
> did then kallsyms_expand_symbol() would overflow the buffer handed to
> it.
> 
> Your suggestion about an explicit length for kallsyms_expand_symbol() is
> the correct one.


  thank you to give me additional chance to send a new patch,
  I will send another patch for it.

  since you find it, firstly, and also give a confirmation.
  can I add you as "Signed-of-by", too ?

  and excuse me:
    I think I should spend time resources to have a test for new patch.
    so I will finish it within this weekend (2013-4-14), is it OK ?


  thanks.


-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/