linux-kernel - Re: [PATCH v3 2/3] media: davinci: vpbe: venc: move the enabling of vpss clocks to driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 9 Apr 2013 15:33:44 +0530
From:	Prabhakar Lad <prabhakar.csengg@...il.com>
To:	Sekhar Nori <nsekhar@...com>
Cc:	DLOS <davinci-linux-open-source@...ux.davincidsp.com>,
	LAK <linux-arm-kernel@...ts.infradead.org>,
	LMML <linux-media@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Mauro Carvalho Chehab <mchehab@...hat.com>
Subject: Re: [PATCH v3 2/3] media: davinci: vpbe: venc: move the enabling of
 vpss clocks to driver

On Tue, Apr 9, 2013 at 3:27 PM, Sekhar Nori <nsekhar@...com> wrote:
>
>
> On 4/8/2013 5:49 PM, Prabhakar lad wrote:
>> From: Lad, Prabhakar <prabhakar.csengg@...il.com>
>>
>> The vpss clocks were enabled by calling a exported function from a driver
>> in a machine code. calling driver code from platform code is incorrect way.
>>
>> This patch fixes this issue and calls the function from driver code itself.
>>
>> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@...il.com>
>> ---
>>  drivers/media/platform/davinci/vpbe_venc.c |   25 +++++++++++++++++++++++++
>>  1 files changed, 25 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/media/platform/davinci/vpbe_venc.c b/drivers/media/platform/davinci/vpbe_venc.c
>> index f15f211..91d0272 100644
>> --- a/drivers/media/platform/davinci/vpbe_venc.c
>> +++ b/drivers/media/platform/davinci/vpbe_venc.c
>> @@ -202,6 +202,25 @@ static void venc_enabledigitaloutput(struct v4l2_subdev *sd, int benable)
>>       }
>>  }
>>
>> +static void
>> +venc_enable_vpss_clock(int venc_type,
>> +                    enum vpbe_enc_timings_type type,
>> +                    unsigned int pclock)
>> +{
>> +     if (venc_type == VPBE_VERSION_1)
>> +             return;
>> +
>> +     if (venc_type == VPBE_VERSION_2 && (type == VPBE_ENC_STD ||
>> +         (type == VPBE_ENC_DV_TIMINGS && pclock <= 27000000))) {
>
> checkpatch --strict will throw a "Alignment should match open
> parenthesis" check here. You may want to fix before you send the pull
> request. No need to resend the patch just for this.
>
OK, thanks will fix it while issuing the pull.

Regards,
--Prabhakar

> Thanks,
> Sekhar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/