linux-kernel - Re: [PATCH] usb: ehci-s5p: fix: Fix null pointer dereferencing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201304091226.58822.arnd@arndb.de>
Date:	Tue, 9 Apr 2013 12:26:58 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Vivek Gautam <gautam.vivek@...sung.com>
Cc:	linux-usb@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	linux-kernel@...r.kernel.org, gregkh@...uxfoundation.org,
	stern@...land.harvard.edu, kgene.kim@...sung.com,
	Manjunath Goudar <manjunath.goudar@...aro.org>,
	Jingoo Han <jg1.han@...sung.com>
Subject: Re: [PATCH] usb: ehci-s5p: fix: Fix null pointer dereferencing

On Tuesday 09 April 2013, Vivek Gautam wrote:
> 
> 7edb3da makes ehci-s5p as a separate driver. But,
> it raised an issue with its driver data.
> Now that 's5p_ehci_hcd' doesn't maintain pointer to 'usb_hcd'
> and s5p_ehci is nothing but a pointer to hcd->priv;
> add hcd to the driver data rather than s5p_ehci.
> 
> This fixes issues with null pointer dereferencing in
> s5p_ehci_shutdown(), s5p_ehci_suspend(), s5p_ehci_resume().

Right, sorry for not spotting this during review.

> Signed-off-by: Vivek Gautam <gautam.vivek@...sung.com>
> CC: Manjunath Goudar <manjunath.goudar@...aro.org>
> CC: Arnd Bergmann <arnd@...db.de>
> CC: Jingoo Han <jg1.han@...sung.com>

Acked-by: Arnd Bergmann <arnd@...db.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/