linux-kernel - Re: [PATCH 0/2] hfs/hfsplus: Modernize logging styles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1365505580.2482.35.camel@slavad-ubuntu>
Date:	Tue, 09 Apr 2013 15:06:20 +0400
From:	Vyacheslav Dubeyko <slava@...eyko.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Hin-Tak Leung <htl10@...rs.sourceforge.net>,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] hfs/hfsplus: Modernize logging styles

On Tue, 2013-04-09 at 03:39 -0700, Joe Perches wrote:
> On Tue, 2013-04-09 at 11:08 +0400, Vyacheslav Dubeyko wrote:
> > On Mon, 2013-04-08 at 09:37 -0700, Joe Perches wrote:
> > > Joe Perches (2):
> > >   hfs/hfsplus: Convert dprint to hfs_dbg
> > >   hfs/hfsplus: Convert printks to pr_<level>
> []
> > But I have some additional suggestions:
> > (1) I think that it makes sense to use no_printk() for the case when we
> > don't need in debug output.
> 
> I don't.
> 
> no_printk is used simply to get gcc to verify
> format and args with __printf().
> 
> The equivalent is already done by the
> 	if (DBG_##FLAG & DBG_MASK)
> 		printk(...)
> when DBG_MASK is 0
> 

Ok. I agree.

> > (2) I think that it is really necessary to add info about file and line
> > number for the case of debug output.
> 
> I don't.  I think file/line is pretty useless.
> 

I don't think so. Namely during debugging the file/line info is very
useful, from my point of view. So, I think that this adding makes sense.

> Adding dynamic_debug could be useful, but that's
> another patch.
> 
> Also, checkpatch can be a useful tool, but all
> its warnings aren't necessary to always be fixed.
> 

As I see, the goal of this patch set is overcome of checkpatch warnings.
I'd prefer not change the style of error messages in HFS/HFS+ drivers.
But this patch set makes sense because it fixes warnings of checkpatch
related to error messages.

Moreover, as I see the most of rest checkpatch's warnings makes sense
and it needs to be fixed, from my point of view.

> Also, please remember to trim your replies.
> It's not necessary to quote the entire email.
> Just quote the useful contextual bits.
> _Lots_ of people read this list and you can
> cause a lot to waste time looking for additional
> comments you don't make.

Sorry. It's my mistake.

With the best regards,
Vyacheslav Dubeyko.

> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/