linux-kernel - Re: [PATCH] kernel: trace: ftrace: strncpy, using strlcpy instead of strncpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1365519626.25498.58.camel@gandalf.local.home>
Date:	Tue, 09 Apr 2013 11:00:26 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Chen Gang <gang.chen@...anux.com>
Cc:	Frederic Weisbecker <fweisbec@...il.com>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kernel: trace: ftrace: strncpy, using strlcpy instead
 of strncpy

I'll queue this up for my 3.10 queue. I'm going to merge this patch with
the previous patch you sent that updates trace.c

Thanks,

-- Steve

On Mon, 2013-04-08 at 12:12 +0800, Chen Gang wrote:
>   for NUL terminated string, need always set '\0' at the end.
> 
> Signed-off-by: Chen Gang <gang.chen@...anux.com>
> ---
>  kernel/trace/ftrace.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index dfd33f0..fa984b7 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -3492,14 +3492,14 @@ static char ftrace_filter_buf[FTRACE_FILTER_SIZE] __initdata;
>  
>  static int __init set_ftrace_notrace(char *str)
>  {
> -	strncpy(ftrace_notrace_buf, str, FTRACE_FILTER_SIZE);
> +	strlcpy(ftrace_notrace_buf, str, FTRACE_FILTER_SIZE);
>  	return 1;
>  }
>  __setup("ftrace_notrace=", set_ftrace_notrace);
>  
>  static int __init set_ftrace_filter(char *str)
>  {
> -	strncpy(ftrace_filter_buf, str, FTRACE_FILTER_SIZE);
> +	strlcpy(ftrace_filter_buf, str, FTRACE_FILTER_SIZE);
>  	return 1;
>  }
>  __setup("ftrace_filter=", set_ftrace_filter);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/