linux-kernel - Re: [PATCH 1/1] irqchip: exynos-combiner: Fix checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 9 Apr 2013 08:33:59 +0530
From:	Sachin Kamat <sachin.kamat@...aro.org>
To:	linux-kernel@...r.kernel.org
Cc:	tglx@...utronix.de, sachin.kamat@...aro.org, patches@...aro.org,
	chanho61.park@...sung.com, kgene.kim@...sung.com
Subject: Re: [PATCH 1/1] irqchip: exynos-combiner: Fix checkpatch warnings

Hi Kukjin,

On 13 March 2013 14:42, Sachin Kamat <sachin.kamat@...aro.org> wrote:
> Fixes the following warnings:
> WARNING: line over 80 characters
> WARNING: Prefer pr_warn(... to pr_warning(...
>
> Signed-off-by: Sachin Kamat <sachin.kamat@...aro.org>
> ---
>  drivers/irqchip/exynos-combiner.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c
> index e8501db..66b1bf5 100644
> --- a/drivers/irqchip/exynos-combiner.c
> +++ b/drivers/irqchip/exynos-combiner.c
> @@ -229,13 +229,15 @@ void __init combiner_init(void __iomem *combiner_base,
>         irq_base = irq_alloc_descs(COMBINER_IRQ(0, 0), 1, nr_irq, 0);
>         if (IS_ERR_VALUE(irq_base)) {
>                 irq_base = COMBINER_IRQ(0, 0);
> -               pr_warning("%s: irq desc alloc failed. Continuing with %d as linux irq base\n", __func__, irq_base);
> +               pr_warn("%s: irq desc alloc failed. "
> +                       "Continuing with %d as linux irq base\n",
> +                       __func__, irq_base);
>         }
>
>         combiner_irq_domain = irq_domain_add_legacy(np, nr_irq, irq_base, 0,
>                                 &combiner_irq_domain_ops, &combiner_data);
>         if (WARN_ON(!combiner_irq_domain)) {
> -               pr_warning("%s: irq domain init failed\n", __func__);
> +               pr_warn("%s: irq domain init failed\n", __func__);
>                 return;
>         }
>
> --
> 1.7.4.1
>

ChanHo said you would be picking this patch. Please check.

-- 
With warm regards,
Sachin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/