linux-kernel - RE: [PATCH] x86, mce: Print warning if MCE handler fails to register /dev/mcelog

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3908561D78D1C84285E8C5FCA982C28F1EA41C2B@ORSMSX104.amr.corp.intel.com>
Date:	Tue, 9 Apr 2013 18:30:58 +0000
From:	"Luck, Tony" <tony.luck@...el.com>
To:	Khalid Aziz <khalid.aziz@...cle.com>,
	"bp@...en8.de" <bp@...en8.de>,
	"tglx@...utronix.de" <tglx@...utronix.de>,
	"mingo@...hat.com" <mingo@...hat.com>,
	"hpa@...or.com" <hpa@...or.com>
CC:	"x86@...nel.org" <x86@...nel.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] x86, mce: Print warning if MCE handler fails to
 register /dev/mcelog

-	misc_register(&mce_chrdev_device);
+	if (misc_register(&mce_chrdev_device) != 0)
+		pr_warn("Failed to register mcelog device\n");

Did this actually happen to you?  Or is this just "good practice" to check the
return value from misc_register?

If this can really happen, we should remember that it failed and
just drop out of mce_log() early (no point in queueing up records
when there is no way for a user to ever access them).

-Tony