linux-kernel - Re: [PATCH 1/1] irqchip: exynos-combiner: Fix checkpatch warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1365479133.6865.1.camel@joe-AO722>
Date:	Mon, 08 Apr 2013 20:45:33 -0700
From:	Joe Perches <joe@...ches.com>
To:	Sachin Kamat <sachin.kamat@...aro.org>
Cc:	linux-kernel@...r.kernel.org, tglx@...utronix.de,
	patches@...aro.org, chanho61.park@...sung.com,
	kgene.kim@...sung.com
Subject: Re: [PATCH 1/1] irqchip: exynos-combiner: Fix checkpatch warnings

On Tue, 2013-04-09 at 09:06 +0530, Sachin Kamat wrote:
> On 9 April 2013 08:39, Joe Perches <joe@...ches.com> wrote:
> > On Tue, 2013-04-09 at 08:33 +0530, Sachin Kamat wrote:
> >> On 13 March 2013 14:42, Sachin Kamat <sachin.kamat@...aro.org> wrote:
> >> > Fixes the following warnings:
> >> > WARNING: line over 80 characters
> >> > WARNING: Prefer pr_warn(... to pr_warning(...
> >> > diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c
> > []
> >> > @@ -229,13 +229,15 @@ void __init combiner_init(void __iomem *combiner_base,
> > []
> >> > -               pr_warning("%s: irq desc alloc failed. Continuing with %d as linux irq base\n", __func__, irq_base);
> >> > +               pr_warn("%s: irq desc alloc failed. "
> >> > +                       "Continuing with %d as linux irq base\n",
> >> > +                       __func__, irq_base);
> >
> > Please don't split formats.
> > See Documentation/CodingStyle Chapter 2
> >
> >                 pr_warn("%s: irq desc alloc failed. Continuing with %d as linux irq base\n",
> >                         __func__, irq_base);
> >
> >
> 
> Thanks for pointing out. If I didn't split it, it would have exceeded
> the 80 column limit.

So?

> Since there were 2 different sentences, I thought
> grepping should not be a problem if split at sentence boundaries.

I think it's OK to split at \n but not necessarily
at a sentence boundary/period.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/