| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <201304092238.07286.arnd@arndb.de> Date: Tue, 9 Apr 2013 22:38:07 +0200 From: Arnd Bergmann <arnd@...db.de> To: Lee Jones <lee.jones@...aro.org> Cc: linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linus.walleij@...ricsson.com Subject: Re: [PATCH 5/8] dmaengine: ste_dma40: Ensure src and dst registers are configured correctly On Tuesday 09 April 2013, Lee Jones wrote: > On Tue, 09 Apr 2013, Arnd Bergmann wrote: > > > On Tuesday 09 April 2013, Lee Jones wrote: > > > Confusingly d40_log_cfg() is used to set up the logical channel > > > configuration registers, but d40_phy_cfg() is used to configure > > > physical and logical registers, so it should be called in both > > > cases. It is the function call's final attribute which determines > > > whether it's a physical or logical channel, not whether the > > > function is called or not. > > > > So how did it ever work? Your description sounds like it was > > broken all along, but I would assume that someone tested the code. > > From what I can see, not. > > My best guess is that the 'test' was to see if the configuration > changed using the debug print at the end of the function. I don't see > how else the configuration can be written to hardware. Acked-by: Arnd Bergmann <arnd@...db.de> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists