linux-kernel - Re: [PATCH v3] [RESEND] mm: Make snapshotting pages for stable writes a per-bio operation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130409211128.GD15214@quack.suse.cz>
Date:	Tue, 9 Apr 2013 23:11:28 +0200
From:	Jan Kara <jack@...e.cz>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	"Darrick J. Wong" <darrick.wong@...cle.com>,
	Jan Kara <jack@...e.cz>, Mel Gorman <mgorman@...e.de>,
	Shuge <shugelinux@...il.com>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, linux-ext4@...r.kernel.org,
	Kevin <kevin@...winnertech.com>, Theodore Ts'o <tytso@....edu>,
	Jens Axboe <axboe@...nel.dk>,
	Catalin Marinas <catalin.marinas@....com>,
	Will Deacon <will.deacon@....com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v3] [RESEND] mm: Make snapshotting pages for stable
 writes a per-bio operation

On Tue 09-04-13 14:04:32, Andrew Morton wrote:
> On Tue, 9 Apr 2013 11:06:17 -0700 "Darrick J. Wong" <darrick.wong@...cle.com> wrote:
> 
> > +		 * Here we write back pagecache data that may be mmaped. Since
> > +		 * we cannot afford to clean the page and set PageWriteback
> > +		 * here due to lock ordering (page lock ranks above transaction
> > +		 * start), the data can change while IO is in flight. Tell the
> > +		 * block layer it should bounce the bio pages if stable data
> > +		 * during write is required.
> 
> I think there are already ab/ba deadlocks between lock_page() and
> journal_start().  iirc one path was write(), I forget which was the
> other path.  This was 10+ years ago and nobody else noticed and I
> didn't know how to fix it so I didn't tell anyone ;)
  Hum, I don't think they are there anymore ;)

> It would be neat to be able to hook things like journal_start() into
> lockdep but I don't think that lockdep has easy provision for wiring
> oddball things into its mechanisms.
  Actually if you look at fs/jbd/transaction.c:start_this_handle(), you
will notice that it is wired into lockdep (the lock_map_acquire() call
there). And it works since I've seen quite some reports from it ;)

								Honza
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/