lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 09 Apr 2013 14:50:54 -0700 From: James Bottomley <James.Bottomley@...senPartnership.com> To: Andy Whitcroft <apw@...onical.com>, Joe Perches <joe@...ches.com> Cc: linux-kernel <linux-kernel@...r.kernel.org>, linux-scsi <linux-scsi@...r.kernel.org> Subject: checkpatch: kill the bogus camelcase check It's making checkpatch unusable on most drivers because it's spewing tons of bogus warnings. The problem is the assumption that studly caps is always wrong: it isn't if the variables are named after the various conventions in the hardware programming guides (which are usually written by Microsoft people). In order to encourage people to use checkpatch, it has to be *useful* it can't stray too far into dogmatic things like this that are essentially unfixable by most people who submit patches. Signed-off-by: James Bottomley <JBottomley@...allels.com> --- diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index b28cc38..5588dd3 100755 --- a/scripts/checkpatch.pl +++ b/scripts/checkpatch.pl @@ -1398,8 +1398,6 @@ sub process { my %suppress_export; my $suppress_statement = 0; - my %camelcase = (); - # Pre-scan the patch sanitizing the lines. # Pre-scan the patch looking for any __setup documentation. # @@ -2925,19 +2923,6 @@ sub process { } } -#CamelCase - while ($line =~ m{($Constant|$Lval)}g) { - my $var = $1; - if ($var !~ /$Constant/ && - $var =~ /[A-Z]\w*[a-z]|[a-z]\w*[A-Z]/ && - $var !~ /"^(?:Clear|Set|TestClear|TestSet|)Page[A-Z]/ && - !defined $camelcase{$var}) { - $camelcase{$var} = 1; - WARN("CAMELCASE", - "Avoid CamelCase: <$var>\n" . $herecurr); - } - } - #no spaces allowed after \ in define if ($line=~/\#\s*define.*\\\s$/) { WARN("WHITESPACE_AFTER_LINE_CONTINUATION", -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists