linux-kernel - Re: [PATCH v2] bitmap: speedup in bitmap_find_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130408211859.b5549325.akpm@linux-foundation.org>
Date:	Mon, 8 Apr 2013 21:18:59 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Chanho Min <chanho.min@....com>,
	Nadia Yvette Chambers <nyc@...omorphy.com>,
	Jiri Kosina <jkosina@...e.cz>,
	Guennadi Liakhovetski <lg@...x.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] bitmap: speedup in bitmap_find_free_region when
 order is 0

On Mon, 08 Apr 2013 20:18:20 -0700 Joe Perches <joe@...ches.com> wrote:

> On Mon, 2013-04-08 at 20:10 -0700, Andrew Morton wrote:
> > > --- a/lib/bitmap.c
> []
> > > +	for (i = 0 ; i < nlongs_reg ; i++) {
> > 
> > No space before the semicolon, please.  checkpatch should warn about
> > this but it seems to be broken.
> 
> There's no specific CodingStyle violation here

Let's fix CodingStyle then?  Nobody puts spaces before semis - perish
the thought!  (I count 4,254,057 versus 8,416 in .c)

> Adding --strict does bleat though.

And let's make it default please.

> # check for whitespace before a non-naked semicolon
> 		if ($line =~ /^\+.*\S\s+;/) {
> 			CHK("SPACING",
> 			    "space prohibited before semicolon\n" . $herecurr);
> 		}
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/