[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.2.02.1304092155220.25293@chino.kir.corp.google.com>
Date: Tue, 9 Apr 2013 22:52:11 -0700 (PDT)
From: David Rientjes <rientjes@...gle.com>
To: Toshi Kani <toshi.kani@...com>
cc: Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
linux-kernel@...r.kernel.org, linuxram@...ibm.com,
guz.fnst@...fujitsu.com, tmac@...com,
isimatu.yasuaki@...fujitsu.com, wency@...fujitsu.com,
tangchen@...fujitsu.com, jiang.liu@...wei.com
Subject: Re: [PATCH v2 0/3] Support memory hot-delete to boot memory
On Mon, 8 Apr 2013, Toshi Kani wrote:
> > So we don't need this new code if CONFIG_MEMORY_HOTPLUG=n? If so, can
> > we please arrange for it to not be present if the user doesn't need it?
>
> Good point! Yes, since the new function is intended for memory
> hot-delete and is only called from __remove_pages() in
> mm/memory_hotplug.c, it should be added as #ifdef CONFIG_MEMORY_HOTPLUG
> in PATCH 2/3.
>
> I will make the change, and send an updated patch to PATCH 2/3.
>
It should actually depend on CONFIG_MEMORY_HOTREMOVE, but the pseries
OF_RECONFIG_DETACH_NODE code seems to be the only code that doesn't
make that distinction. CONFIG_MEMORY_HOTREMOVE acts as a wrapper to
protect configs that don't have ARCH_ENABLE_MEMORY_HOTREMOVE, so we'll
want to keep it around and presumably that powerpc code depends on it as
well.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists