linux-kernel - Re: [PATCH] Do not force shutdown/reboot to boot cpu.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130410111620.GB29752@gmail.com>
Date:	Wed, 10 Apr 2013 13:16:20 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Robin Holt <holt@....com>
Cc:	"H. Peter Anvin" <hpa@...or.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Russ Anderson <rja@....com>,
	Shawn Guo <shawn.guo@...aro.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>, x86@...nel.org,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] Do not force shutdown/reboot to boot cpu.


* Robin Holt <holt@....com> wrote:

> On Mon, Apr 08, 2013 at 09:11:06AM -0700, H. Peter Anvin wrote:
> > On 04/08/2013 08:57 AM, Ingo Molnar wrote:
> > > 
> > > I think the original commit:
> > > 
> > >   f96972f2dc63 kernel/sys.c: call disable_nonboot_cpus() in kernel_restart()
> > > 
> > > actually regressed your 1024 CPU systems, and should possibly be reverted or fixed 
> > > in some other fashion - such as by migrating to the primary CPU (on architectures 
> > > that require that), instead of hotplug offlining every secondary CPU on every 
> > > architecture!
> > > 
> > > Alternatively, disable_nonboot_cpus() could perhaps be improved to down CPUs in 
> > > parallel: issue the CPU-down requests to every CPU, then wait for them to complete 
> > > - instead of the loop over every CPU?
> > > 
> > > This would be the conceptual counter part to parallel boot up of CPUs - something 
> > > SGI might be interested in as well?
> > > 
> > 
> > Migrating to the boot processor and then calling stop_machine() to
> > defang any other processors should be sufficient, no?
> > 
> > I don't know if there is any reason to deschedule all tasks?
> 
> My reading of the original commit indicated that some architecture's
> firmware needs the boot cpu to be the one initiating reboot.
> 
> If that is correct, then I can not see why a stop_machine() implementation
> will not work.
> 
> Since this is in generic kernel code, how can I proceed?

I think rebooting on the same CPU where we booted up is something worth having in 
general, as a firmware robustness feature. (assuming the CPU in question is still 
online)

We have similar constraints in the suspend code for example - some x86 firmware 
breaks if suspend related ACPI calls are not done on the boot CPU ...

So how about restoring the old "just reboot, don't shut down the others" behavior, 
extended with a "reboot on the CPU that booted up" reboot affinity logic?

That should fix the 1024 CPUs regression, and it should also keep those ARM 
systems working - without any special casing.

Of course I'd also be entirely happy about having true parallel shutdown...

It does not have to be entirely threaded: I bet most of the shutdown latency is in 
a few paranoia udelay()s or so, where some simple global lock could be dropped.

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/