linux-kernel - Re: [PATCH] gpio / ACPI: Handle ACPI events in accordance with the spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZ+Tj2tdQsY7dM+ZJHDeO=HdnYtQ8fWVAXRbP0zpG8ijA@mail.gmail.com>
Date:	Wed, 10 Apr 2013 23:06:48 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	"Rafael J. Wysocki" <rjw@...k.pl>
Cc:	Mathias Nyman <mathias.nyman@...ux.intel.com>,
	Grant Likely <grant.likely@...retlab.ca>,
	ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio / ACPI: Handle ACPI events in accordance with the spec

On Tue, Apr 9, 2013 at 3:57 PM, Rafael J. Wysocki <rjw@...k.pl> wrote:

> From: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>
> Commit 0d1c28a (gpiolib-acpi: Add ACPI5 event model support to gpio.)
> that added support for ACPI events signalled through GPIO interrupts
> covered only GPIO pins whose numbers are less than or equal to 255.
> However, there may be GPIO pins with numbers greater than 255 and
> the ACPI spec (ACPI 5.0, Section 5.6.5.1) requires the _EVT method
> to be used for handling events corresponding to those pins.
>
> Moreover, according to the spec, _EVT is the default mechanism
> for handling all ACPI events signalled through GPIO interrupts,
> so if the _Exx/_Lxx method is not present for the given pin,
> _EVT should be used instead.  If present, though, _Exx/_Lxx take
> precedence over _EVT which shouldn't be executed in that case
> (ACPI 5.0, Section 5.6.5.3).
>
> Modify acpi_gpiochip_request_interrupts() to follow the spec as
> described above and add acpi_gpiochip_free_interrupts() needed
> to free interrupts associated with _EVT.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@...el.com>

Patch applied with Mika's ACK, thanks!

It's not like I fully understand it, but I totally trust you guys.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/