linux-kernel - Re: [PATCH] kernel: auditfilter: looping issue, memory leak if has 2 or more AUDIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <803399362.12318964.1365629578422.JavaMail.root@redhat.com>
Date:	Wed, 10 Apr 2013 17:32:58 -0400 (EDT)
From:	Eric Paris <eparis@...hat.com>
To:	Chen Gang <gang.chen@...anux.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel: auditfilter: looping issue, memory leak if has
 2 or more AUDIT_FILTERKEYs

----- Original Message -----
> 
>   also for function audit_list:
>     when call audit_make_reply fails (will return NULL).
>     we need free all its related variables instead of only kfree rull.
>       (such as call autit_free_rule)
> 
>   please help check, thanks.

audit_free_rule() takes a struct audit_entry, not an audit_rule.  struct audit_rule does not have additional things which need to be freed...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/