linux-kernel - Re: [PATCH v2] MODSIGN: do not send garbage to stderr when enabling modules signature

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87hajd4t0y.fsf@rustcorp.com.au>
Date:	Thu, 11 Apr 2013 13:29:09 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	David Cohen <david.a.cohen@...el.com>
Cc:	dhowells@...hat.com, linux-kernel@...r.kernel.org,
	mark.gross@...el.com
Subject: Re: [PATCH v2] MODSIGN: do not send garbage to stderr when enabling modules signature

David Cohen <david.a.cohen@...el.com> writes:
> On 04/10/2013 03:32 AM, Rusty Russell wrote:
>> David Cohen <david.a.cohen@...el.com> writes:
>>> openssl may send garbage to stderr when generating X.509 key pair for
>>> modules signature regardless there was an error or not. It makes more
>>> difficult to create scripts based on kernel error/warning messages.
>>>
>>> When compiling kernel with -jN (N > 1), all warning/error messages
>>> printed while openssl is generating key pair may get mixed dots and
>>> other symbols openssl sends to stderr. This patch makes sure openssl
>>> logs go to default stdout.
>> Ah!  Not garbage, but it writes progress dots and status messages to
>> stderr?
>>
>> I trimmed your commit message as shown below.
>
> Thanks! The new commit message looks fine.
> But it's not the dots. It prints the whole logs to stderr, but the dots 
> are more likely to get mixed.
>
> Br, David

Seems like Linus didn't bite, so I've put it in my modules-next tree.

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/