linux-kernel - Re: [RESEND][PATCH v5 2/3] fix hugetlb memory check in vma_dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130411070832.GA1488@dhcp22.suse.cz>
Date:	Thu, 11 Apr 2013 09:08:40 +0200
From:	Michal Hocko <mhocko@...e.cz>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Mel Gorman <mgorman@...e.de>, Hugh Dickins <hughd@...gle.com>,
	Rik van Riel <riel@...hat.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Konstantin Khlebnikov <khlebnikov@...nvz.org>,
	HATAYAMA Daisuke <d.hatayama@...fujitsu.com>,
	linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [RESEND][PATCH v5 2/3] fix hugetlb memory check in
 vma_dump_size()

On Wed 10-04-13 14:49:07, David Rientjes wrote:
> On Wed, 10 Apr 2013, Naoya Horiguchi wrote:
> 
> > Documentation/filesystems/proc.txt says about coredump_filter bitmask,
> > 
> >   Note bit 0-4 doesn't effect any hugetlb memory. hugetlb memory are only
> >   effected by bit 5-6.
> > 
> > However current code can go into the subsequent flag checks of bit 0-4
> > for vma(VM_HUGETLB). So this patch inserts 'return' and makes it work
> > as written in the document.
> > 
> > Signed-off-by: Naoya Horiguchi <n-horiguchi@...jp.nec.com>
> > Reviewed-by: Rik van Riel <riel@...hat.com>
> > Acked-by: Michal Hocko <mhocko@...e.cz>
> > Reviewed-by: HATAYAMA Daisuke <d.hatayama@...fujitsu.com>
> > Acked-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
> > Cc: stable@...r.kernel.org
> 
> Acked-by: David Rientjes <rientjes@...gle.com>
> 
> Stable for 2.6.34+.

I think it is only 3.7+ as well because VM_RESERVED stopped use before
(314e51b9).

-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/