linux-kernel - Re: [PATCH 3.8-stable] GFS2: return error if malloc failed in gfs2_rs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1365667197.2701.13.camel@menhir>
Date:	Thu, 11 Apr 2013 08:59:57 +0100
From:	Steven Whitehouse <swhiteho@...hat.com>
To:	Jonghwan Choi <jhbird.choi@...sung.com>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	"'Wei Yongjun'" <yongjun_wei@...ndmicro.com.cn>
Subject: Re: [PATCH 3.8-stable] GFS2: return error if malloc failed in
 gfs2_rs_alloc()

Hi,

On Thu, 2013-04-11 at 11:03 +0900, Jonghwan Choi wrote:
> This patch looks like it should be in the 3.8-stable tree, should we apply
> it?
> 
Yes, again looks like a good plan,

Steve.

> ------------------
> 
> From: "Wei Yongjun <yongjun_wei@...ndmicro.com.cn>"
> 
> commit 441362d06be349430d06e37286adce4b90e6ce96 upstream
> 
> The error code in gfs2_rs_alloc() is set to ENOMEM when error
> but never be used, instead, gfs2_rs_alloc() always return 0.
> Fix to return 'error'.
> 
> Signed-off-by: Wei Yongjun <yongjun_wei@...ndmicro.com.cn>
> Signed-off-by: Steven Whitehouse <swhiteho@...hat.com>
> Signed-off-by: Jonghwan Choi <jhbird.choi@...sung.com>
> ---
>  fs/gfs2/rgrp.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/gfs2/rgrp.c b/fs/gfs2/rgrp.c
> index b7eff07..9afba3d6 100644
> --- a/fs/gfs2/rgrp.c
> +++ b/fs/gfs2/rgrp.c
> @@ -576,7 +576,7 @@ int gfs2_rs_alloc(struct gfs2_inode *ip)
>  	RB_CLEAR_NODE(&ip->i_res->rs_node);
>  out:
>  	up_write(&ip->i_rw_mutex);
> -	return 0;
> +	return error;
>  }
>  
>  static void dump_rs(struct seq_file *seq, const struct gfs2_blkreserv *rs)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/