linux-kernel - Re: [PATCH 2/6] efivars: Keep a private global pointer to efivars

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5166B62F.4000206@console-pimps.org>
Date:	Thu, 11 Apr 2013 14:10:07 +0100
From:	Matt Fleming <matt@...sole-pimps.org>
To:	Mike Waychison <mikew@...gle.com>
CC:	"linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Matt Fleming <matt.fleming@...el.com>,
	Tom Gundersen <teg@...m.no>
Subject: Re: [PATCH 2/6] efivars: Keep a private global pointer to efivars

On 09/04/13 23:07, Mike Waychison wrote:
>> +config EFI_VARS_GENERIC_OPS
>> +       bool
>> +       depends on EFI
>> +       depends on !GOOGLE_SMI
>> +       default y
>> +
> 
> So while we have no need to support both the gsmi and real efi
> entrypoints on any given machine, we still need to be able to support
> the operation of both from the same kernel build.  How do you feel
> about removing this bit and leaving it such that efivars_init
> continues to register the "generic" efivars regardless of
> CONFIG_GOOGLE_SMI?  The rest of the patch seems fine to me.

OK sure, we can do that. Thanks for the review.

-- 
Matt Fleming, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/