linux-kernel - Re: [PATCH 05/26] comedi: Don't use create_proc_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5166D1BB.3070101@mev.co.uk>
Date:	Thu, 11 Apr 2013 16:07:39 +0100
From:	Ian Abbott <abbotti@....co.uk>
To:	David Howells <dhowells@...hat.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Mori Hess <fmhess@...rs.sourceforge.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	David Schleef <ds@...leef.org>,
	H Hartley Sweeten <hsweeten@...ionengravers.com>,
	Ian Abbott <ian.abbott@....co.uk>,
	"viro@...IV.linux.org.uk" <viro@...IV.linux.org.uk>
Subject: Re: [PATCH 05/26] comedi: Don't use create_proc_read_entry() [RFC]

On 2013-04-11 14:28, David Howells wrote:
> Don't use create_proc_read_entry() as that is deprecated, but rather use
> proc_create_data() and seq_file instead.

It seems to work okay and is simpler than I thought it would be!  You 
changed the mode of the file to 0644 for some reason though.  Please 
change it back to 0444 or S_IFREG | S_IRUGO.  Thanks.

-- 
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@....co.uk>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/