linux-kernel - Re: [PATCH] drm/i915: don't check inconsistent modeset state when force-restoring

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130411191742.GA8251@cantiga.alporthouse.com>
Date:	Thu, 11 Apr 2013 20:17:42 +0100
From:	Chris Wilson <chris@...is-wilson.co.uk>
To:	Daniel Vetter <daniel.vetter@...ll.ch>
Cc:	Intel Graphics Development <intel-gfx@...ts.freedesktop.org>,
	DRI Development <dri-devel@...ts.freedesktop.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Dave Airlie <airlied@...il.com>,
	Tomas Melin <tomas.melin@....fi>,
	Richard Cochran <richardcochran@...il.com>,
	stable@...r.kernel.org
Subject: Re: [PATCH] drm/i915: don't check inconsistent modeset state when
 force-restoring

On Thu, Apr 11, 2013 at 08:22:50PM +0200, Daniel Vetter wrote:
> It will be only consistent once we've restored all the crtcs. Since a
> bunch of other callers also want to just restore a single crtc, add a
> boolean to disable checking only where it doesn't make sense.
> 
> Note that intel_modeset_setup_hw_state already has a call to
> intel_modeset_check_state at the end, so we don't reduce the amount of
> checking.
> 
> v2: Try harder not to create a big patch (Chris).
> 
> v3: Even smaller (still Chris). Also fix a trailing space.
> 
> References: https://lkml.org/lkml/2013/3/16/60
> Cc: Tomas Melin <tomas.melin@....fi>
> Cc: Richard Cochran <richardcochran@...il.com>
> Cc: Chris Wilson <chris@...is-wilson.co.uk>
> Cc: stable@...r.kernel.org
> Signed-off-by: Daniel Vetter <daniel.vetter@...ll.ch>

I'm happy that you are not touching any paths other than mentioned in
the changelog, and that I think being quiet on the modeset is a good use
of the 'force' semantics, so

Reviewed-by: Chris Wilson <chris@...is-wilson.co.uk>
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/