linux-kernel - Re: [PATCH] MFD: ab8500: pass AB8500 IRQ to debugfs code by resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201304121008.51300.arnd@arndb.de>
Date:	Fri, 12 Apr 2013 10:08:51 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Linus Walleij <linus.walleij@...ricsson.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Anmar Oueja <anmar.oueja@...aro.org>,
	Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH] MFD: ab8500: pass AB8500 IRQ to debugfs code by resource

On Friday 12 April 2013, Linus Walleij wrote:
> >
> > I think this won't work because the interrupts in ab8500_debug_resources
> > are now local numbers relative to the ab8500->domain irq_domain,
> > while IRQ_DB8500_AB8500 is an global interrupt number.
> 
> Actually, well, this one IRQ (the one I start to pass) is already
> domain-mapped to the global IRQ numberspace, so that one will
> be correct.

I don't know if we're talking about the same thing here.

My point was that passing a domain-mapped IRQ number into mfd_add_devices
with another domain will result in the attempt to map that number into
another domain, which does not work.

> However the debug driver patch, i.e. the entire debugfs driver,
> is completely irqdomain-unaware and has been broken for
> device tree since forever and broken for non-dt builds since
> the IRQ numbers were made local.
> 
> I guess I'll just have to cook a second patch to fix this up...

The debug driver should not need to worry about domains, as long
as the ab8500->domain passed into mfd_add_devices is correctly
set up.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/