linux-kernel - RE: [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing mutex_unlock if opp_find_freq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <002101ce3776$cbc83f90$6358beb0$@samsung.com>
Date:	Fri, 12 Apr 2013 21:11:00 +0900
From:	"myungjoo.ham" <myungjoo.ham@...sung.com>
To:	"'Rafael J. Wysocki'" <rjw@...k.pl>,
	'Axel Lin' <axel.lin@...ics.com>,
	'Kyungmin Park' <kyungmin.park@...sung.com>,
	'Kukjin Kim' <kgene.kim@...sung.com>
Cc:	"'Rafael J. Wysocki'" <rafael.j.wysocki@...el.com>,
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: RE: [RESEND][PATCH 1/3] PM / devfreq: exynos4_bus: Fix missing
 mutex_unlock if opp_find_freq_floor fails

> On Friday, April 12, 2013 11:52:01 AM 함명주 wrote:
> > > On Friday, April 12, 2013 01:54:18 PM Axel Lin wrote:
> > > > We need to call mutex_unlock() in the error path.
> > > > 
> > > > Signed-off-by: Axel Lin <axel.lin@...ics.com>
> > > 
> > > All three patches applied to linux-pm.git/linux-next.
> > > 
> > > Exynos maintainers, if you have any objections, please holler.
> > > 
> > > Thanks,
> > > Rafael
> > 
> > This patch was included in the last pull-request patchset
> > though the path was updated. (its precedessor patch moved
> > exynos drivers to /drivers/devfreq/exynos/* after adding
> > Exynos common driver files)
> 
> OK, so do you want me to drop it?
> 
> What about the remaining two?

Yes, please drop 1/3. It's duplicated.

The patches 2~3/3 can wait. They are actually not bugfixes.

> 
> Do you have any more devfreq patches for me to take into v3.10?  If so,
> please send a pull request ASAP.
> 
> Thanks,
> Rafael
> 
> 
> > > 
> > > > ---
> > > >  drivers/devfreq/exynos4_bus.c |    3 ++-
> > > >  1 file changed, 2 insertions(+), 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/devfreq/exynos4_bus.c b/drivers/devfreq/exynos4_bus.c
> > > > index 1deee09..54b9615 100644
> > > > --- a/drivers/devfreq/exynos4_bus.c
> > > > +++ b/drivers/devfreq/exynos4_bus.c
> > > > @@ -974,7 +974,8 @@ static int exynos4_busfreq_pm_notifier_event(struct notifier_block *this,
> > > >  			rcu_read_unlock();
> > > >  			dev_err(data->dev, "%s: unable to find a min freq\n",
> > > >  				__func__);
> > > > -			return PTR_ERR(opp);
> > > > +			err = PTR_ERR(opp);
> > > > +			goto unlock;
> > > >  		}
> > > >  		new_oppinfo.rate = opp_get_freq(opp);
> > > >  		new_oppinfo.volt = opp_get_voltage(opp);
> > > > 
> > > -- 
> > > I speak only for myself.
> > > Rafael J. Wysocki, Intel Open Source Technology Center.
> > > 
> > > 
> > > 
> > >        
> > >   
> > >          
> > > 
> 
> -- 
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.
> 
> 
> 
>        
>   
>          
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/