linux-kernel - Re: [PATCH] x86: Default to ARCH=x86 to avoid overriding CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1365784708.18784.158.camel@i7.infradead.org>
Date:	Fri, 12 Apr 2013 17:38:28 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	richard -rw- weinberger <richard.weinberger@...il.com>
Cc:	x86@...nel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: Default to ARCH=x86 to avoid overriding
 CONFIG_64BIT

On Fri, 2013-04-12 at 18:01 +0200, richard -rw- weinberger wrote:
> David,
> 
> On Thu, Dec 20, 2012 at 10:51 PM, David Woodhouse <dwmw2@...radead.org> wrote:
> > -SUBARCH := $(shell uname -m | sed -e s/i.86/i386/ -e s/sun4u/sparc64/ \
> > +SUBARCH := $(shell uname -m | sed -e s/i.86/x86/ -e s/x86_64/x86/ \
> > +                                 -e s/sun4u/sparc64/ \
> >                                   -e s/arm.*/arm/ -e s/sa110/arm/ \
> >                                   -e s/s390x/s390/ -e s/parisc64/parisc/ \
> >                                   -e s/ppc.*/powerpc/ -e s/mips.*/mips/ \
> 
> Why is this change needed? Especially the -e s/x86_64/x86.
> It causes UML to get build for x86 which is a nasty change
> of the default behavior.

Which one? The "new" change of {i.86,x86_64} -> x86, or the pre-existing
ones for s390, parisc, powerpc and mips that it's falling into line
with?

> Before your change you got a UML kernel for the underlying arch just
> by running "make linux ARCH=um".
> Now it will always build a x86 UML kernel, also if you run it on
> x86_64 and one is forced to override
> SUBARCH by hand.

I know this was true a number of years ago when I first submitted this
fix. But I thought the ARCH=x86 UML build had been fixed since then. And
I was fairly sure I'd *tested* that belief when recently resubmitting...

Isn't it merely a case of setting CONFIG_64BIT to the desired value?

-- 
dwmw2

Download attachment "smime.p7s" of type "application/x-pkcs7-signature" (6171 bytes)