linux-kernel - Re: [PATCH v4 21/22] x86, mm: Make init_mem_mapping be able to be called several times

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE9FiQUR7aBP3SURDG610qLOo-4nveGe+39mxDWOhe_0GJqH+A@mail.gmail.com>
Date:	Thu, 11 Apr 2013 19:04:17 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	Konrad Wilk <konrad.wilk@...cle.com>
Cc:	Thomas Renninger <trenn@...e.de>,
	Tang Chen <tangchen@...fujitsu.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Pekka Enberg <penberg@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>, Jacob Shin <jacob.shin@....com>,
	Tejun Heo <tj@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	"H. Peter Anvin" <hpa@...or.com>
Subject: Re: [PATCH v4 21/22] x86, mm: Make init_mem_mapping be able to be
 called several times

On Thu, Apr 11, 2013 at 6:05 PM, Konrad Wilk <konrad.wilk@...cle.com> wrote:
>
> ----- yinghai@...nel.org wrote:
>
>> Prepare to put page table on local nodes.
>>
>> Move calling of init_mem_mapping to early_initmem_init.
>>
>> Rework alloc_low_pages to alloc page table in following order:
>>       BRK, local node, low range
>>
>> Still only load_cr3 one time, otherwise we would break xen 64bit
>> again.
>
> I have asked you in the previous iteration of the patch to fix that comment.

Maybe it is not clear enough.

>
> Please remove it - as it is misleading. The issue with load_cr3 more than
> once has been fixed under the Xen platform.

Peter, can you remove those two lines?
or need to resend -v5?

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/