linux-kernel - [tip:x86/urgent] x86/mm/cpa/selftest: Fix false positive in CPA self test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tip-18699739b60cb60230153ff5475b2ba92be185f9@git.kernel.org>
Date:	Sun, 14 Apr 2013 09:06:39 -0700
From:	tip-bot for Andrea Arcangeli <tipbot@...or.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...nel.org,
	apw@...onical.com, bp@...en8.de, stefan.bader@...onical.com,
	aarcange@...hat.com, mgorman@...e.de, tglx@...utronix.de
Subject: [tip:x86/urgent] x86/mm/cpa/selftest:
  Fix false positive in CPA self test

Commit-ID:  18699739b60cb60230153ff5475b2ba92be185f9
Gitweb:     http://git.kernel.org/tip/18699739b60cb60230153ff5475b2ba92be185f9
Author:     Andrea Arcangeli <aarcange@...hat.com>
AuthorDate: Thu, 11 Apr 2013 15:36:09 +0200
Committer:  Ingo Molnar <mingo@...nel.org>
CommitDate: Fri, 12 Apr 2013 06:39:20 +0200

x86/mm/cpa/selftest: Fix false positive in CPA self test

If the pmd is not present, _PAGE_PSE will not be set anymore.
Fix the false positive.

Reported-by: Ingo Molnar <mingo@...nel.org>
Signed-off-by: Andrea Arcangeli <aarcange@...hat.com>
Cc: Stefan Bader <stefan.bader@...onical.com>
Cc: Andy Whitcroft <apw@...onical.com>
Cc: Mel Gorman <mgorman@...e.de>
Cc: Borislav Petkov <bp@...en8.de>
Link: http://lkml.kernel.org/r/1365687369-30802-1-git-send-email-aarcange@redhat.com
Signed-off-by: Ingo Molnar <mingo@...nel.org>
---
 arch/x86/mm/pageattr-test.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/x86/mm/pageattr-test.c b/arch/x86/mm/pageattr-test.c
index b008656..0e38951 100644
--- a/arch/x86/mm/pageattr-test.c
+++ b/arch/x86/mm/pageattr-test.c
@@ -68,7 +68,7 @@ static int print_split(struct split_state *s)
 			s->gpg++;
 			i += GPS/PAGE_SIZE;
 		} else if (level == PG_LEVEL_2M) {
-			if (!(pte_val(*pte) & _PAGE_PSE)) {
+			if ((pte_val(*pte) & _PAGE_PRESENT) && !(pte_val(*pte) & _PAGE_PSE)) {
 				printk(KERN_ERR
 					"%lx level %d but not PSE %Lx\n",
 					addr, level, (u64)pte_val(*pte));
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/