linux-kernel - Re: arch/s390/lib/uaccess

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1366006517.1878.49.camel@joe-AO722>
Date:	Sun, 14 Apr 2013 23:15:17 -0700
From:	Joe Perches <joe@...ches.com>
To:	Heiko Carstens <heiko.carstens@...ibm.com>
Cc:	Martin Schwidefsky <schwidefsky@...ibm.com>,
	linux-s390@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: arch/s390/lib/uaccess_pt.c: Missing breaks: ?

On Mon, 2013-04-15 at 07:58 +0200, Heiko Carstens wrote:
> On Sun, Apr 14, 2013 at 10:53:27PM -0700, Joe Perches wrote:
> > On Mon, 2013-04-15 at 07:48 +0200, Heiko Carstens wrote:
> > > On Sat, Apr 13, 2013 at 11:06:14PM -0700, Joe Perches wrote:
> > > > Commit ea81531d ("s390/uaccess: fix page table walk")
> > > > added this code.  It looks like it should have break;
> > > > for each case.
> > > no, the fallthrough is on purpose for each case statement.
> > 
> > Hi again.  It might be useful to add /* fallthrough */
> > or some other comment showing it's intentional.
> 
> I might add some comment above the function, since for everybody
> *knowing* the architecture it's obvious ;) that these must be
> fallthroughs.
> How did you stuble across this?

Tony Prisk sent an patch about a duplicated set of
a variable in a switch/case without a break and I
generalized it and found this and another one in
arch/arm. (the arm one was a real defect)

This one looked like it could be intentional (or not),
but I thought I'd ask.

$ grep-2.5.4 -rP --include=*.[ch] "\b(\w+)\s*=[^;]+;\s*(?:case\s+\w+:|default:)\s*\1\s*=" *


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/