linux-kernel - Re: [PATCH] regulator: ab8500: Fix get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130415160726.GF15837@opensource.wolfsonmicro.com>
Date:	Mon, 15 Apr 2013 17:07:26 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Bengt Jönsson <bengt.g.jonsson@...ricsson.com>
Cc:	Axel Lin <axel.lin@...ics.com>, Lee Jones <lee.jones@...aro.org>,
	Yvan FILLION <yvan.fillion@...ricsson.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] regulator: ab8500: Fix get_mode for shared mode
 regulators

On Mon, Apr 15, 2013 at 04:48:03PM +0200, Bengt Jönsson wrote:

> Reverting 500b4ac90d1103 makes sense, but first I want to mention
> two things:

> 1. In some cases it is not even possible to know the actual current
> state of a regulator because it is controlled by HW as well as SW.
> We have several examples of this.

If we're getting diverging statuses here then we need to introduce a
separate function to report the actual hardware state.  The get/set
should be the request.

> 2. regulator_enable/disable also checks the current status before
> setting the regulator. Should these checks be removed as well?

No, the enable state should reflect the state of the request from the
AP.  regulator_get_status() should return the actual physical state.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)