lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 15 Apr 2013 10:34:37 +0800 From: Yijing Wang <wangyijing@...wei.com> To: Bjorn Helgaas <bhelgaas@...gle.com> CC: Tony Luck <tony.luck@...el.com>, "linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Hanjun Guo <guohanjun@...wei.com>, Jiang Liu <jiang.liu@...wei.com>, Fenghua Yu <fenghua.yu@...el.com>, Yinghai Lu <yinghai@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Thierry Reding <thierry.reding@...onic-design.de>, "Rafael J. Wysocki" <rafael.j.wysocki@...el.com> Subject: Re: [PATCH 2/2] PCI/IA64: fix pci_dev->enable_cnt balance when doing pci hotplug >> @@ -383,6 +383,7 @@ struct pci_bus *pci_acpi_scan_root(struct acpi_pci_root *root) >> } >> >> pci_scan_child_bus(pbus); >> + pci_enable_bridges(pbus); >> return pbus; >> >> out3: > > I think that with this patch, if you hot-add a PCI host bridge, you > will call pci_enable_bridges() twice (once in pci_acpi_scan_root() and > again in acpi_pci_root_add()), so there will be an enable_cnt error in > the opposite direction. > > I'd like to see the pci_enable_bridges() calls pushed up into the > generic code because I don't think there's anything arch-specific > about it. Hi Bjorn, Thanks for your review and comments! This is my fault, I forgot we will enable pci bridges when we hot add host bridge. Push pci_enable_bridges() into the generic code is a good idea, so we don't need to consider enabling bridge in pci arch-specific code. In IA64 we don't assign the unassigned resources like other arch. This is also a weak point. I will update this patch and resend soon. Thanks! Yijing. > > . > -- Thanks! Yijing -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists