linux-kernel - Re: [PATCH] pinctrl: vt8500: wmt: Fix checking return value of pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130415202934.GB25053@quad.lixom.net>
Date:	Mon, 15 Apr 2013 13:29:34 -0700
From:	Olof Johansson <olof@...om.net>
To:	Tony Prisk <linux@...sktech.co.nz>
Cc:	Axel Lin <axel.lin@...ics.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: vt8500: wmt: Fix checking return value of
 pinctrl_register()

On Wed, Apr 10, 2013 at 07:30:36AM +1200, Tony Prisk wrote:
> On 10/04/13 03:59, Axel Lin wrote:
> >pinctrl_register() returns NULL on error.
> >
> >Signed-off-by: Axel Lin <axel.lin@...ics.com>
> >---
> >  drivers/pinctrl/vt8500/pinctrl-wmt.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> >diff --git a/drivers/pinctrl/vt8500/pinctrl-wmt.c b/drivers/pinctrl/vt8500/pinctrl-wmt.c
> >index 14400a7..ab63104e 100644
> >--- a/drivers/pinctrl/vt8500/pinctrl-wmt.c
> >+++ b/drivers/pinctrl/vt8500/pinctrl-wmt.c
> >@@ -588,7 +588,7 @@ int wmt_pinctrl_probe(struct platform_device *pdev,
> >  	data->dev = &pdev->dev;
> >  	data->pctl_dev = pinctrl_register(&wmt_desc, &pdev->dev, data);
> >-	if (IS_ERR(data->pctl_dev)) {
> >+	if (!data->pctl_dev) {
> >  		dev_err(&pdev->dev, "Failed to register pinctrl\n");
> >  		return -EINVAL;
> >  	}
> Not sure why I missed this...
> 
> Linus,
> If you're happy with this patch, I'll forward it on to arm-soc to go
> in with the rest.

I was asked to apply this directly, and have done so (to next/drivers).


-Olof
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/