linux-kernel - Re: [PATCH 2/2] audit: remove unnecessary #if CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20130415140230.60917c685decaeb2b7fb0452@linux-foundation.org>
Date:	Mon, 15 Apr 2013 14:02:30 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Gao feng <gaofeng@...fujitsu.com>
Cc:	viro@...iv.linux.org.uk, eparis@...hat.com,
	linux-kernel@...r.kernel.org, linux-audit@...hat.com
Subject: Re: [PATCH 2/2] audit: remove unnecessary #if CONFIG_AUDIT

On Fri, 12 Apr 2013 17:34:21 +0800 Gao feng <gaofeng@...fujitsu.com> wrote:

> The files include kernel/audit.h are complied only
> when CONFIG_AUDIT is set.
> 
> Just like audit_pid,there is no need to surround
> audit_ever_enabled with CONFIG_AUDIT.
> 
> Signed-off-by: Gao feng <gaofeng@...fujitsu.com>
> ---
>  kernel/audit.h | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/kernel/audit.h b/kernel/audit.h
> index d06ffc1..11468d9 100644
> --- a/kernel/audit.h
> +++ b/kernel/audit.h
> @@ -59,9 +59,7 @@ struct audit_entry {
>  	struct audit_krule	rule;
>  };
>  
> -#ifdef CONFIG_AUDIT
>  extern int audit_ever_enabled;
> -#endif
>  
>  extern int audit_pid;

Well actually there's no need to put the ifdefs around such an extern
declaration at all.  The one small downside to omitting the ifdefs is
that a programming mistake may then be revealed at link-time instead of
at compile-time.  But we very often omit the ifdefs, because reducing visual
clutter is more important.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/