linux-kernel - Re: [PATCH] usb: xhci-dbg: Display endpoint number and direction in context dump

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130415222446.GA13515@xanatos>
Date:	Mon, 15 Apr 2013 15:24:46 -0700
From:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>
To:	Julius Werner <jwerner@...omium.org>
Cc:	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Vincent Palatin <vpalatin@...omium.org>
Subject: Re: [PATCH] usb: xhci-dbg: Display endpoint number and direction in
 context dump

On Mon, Apr 08, 2013 at 05:18:25PM -0700, Julius Werner wrote:
> diff --git a/drivers/usb/host/xhci-dbg.c b/drivers/usb/host/xhci-dbg.c
> index 5f3a7c7..16a8272 100644
> --- a/drivers/usb/host/xhci-dbg.c
> +++ b/drivers/usb/host/xhci-dbg.c
> @@ -503,11 +503,14 @@ static void xhci_dbg_ep_ctx(struct xhci_hcd *xhci,
>  	if (last_ep < 31)
>  		last_ep_ctx = last_ep + 1;
>  	for (i = 0; i < last_ep_ctx; ++i) {
> +		unsigned int epaddr = xhci_get_endpoint_address(i);
>  		struct xhci_ep_ctx *ep_ctx = xhci_get_ep_ctx(xhci, ctx, i);
>  		dma_addr_t dma = ctx->dma +
>  			((unsigned long)ep_ctx - (unsigned long)ctx->bytes);
>  
> -		xhci_dbg(xhci, "Endpoint %02d Context:\n", i);
> +		xhci_dbg(xhci, "Endpoint %02d %s Context (index %02d):\n",

Sorry, one more nitpick.  Can you reword this to be like "Out Endpoint 0x80
Context i" instead of "Endpoint 0x80 OUT Context"?  There are input
contexts and output contexts in xHCI, and I want to imply the endpoint
is either IN or OUT, not the context.

Sarah Sharp
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/