linux-kernel - Re: [PATCH] RTC: rtc-twl: Convert to module_platform_driver() and relocate reg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <516D0790.7090902@iki.fi>
Date:	Tue, 16 Apr 2013 11:10:56 +0300
From:	Tomi Valkeinen <tomi.valkeinen@....fi>
To:	Peter Ujfalusi <peter.ujfalusi@...com>
CC:	Alessandro Zummo <a.zummo@...ertech.it>,
	Tony Lindgren <tony@...mide.com>, rtc-linux@...glegroups.com,
	linux-kernel@...r.kernel.org, linux-omap@...r.kernel.org,
	Christoph Fritz <chf.fritz@...glemail.com>,
	Grygorii Strashko <grygorii.strashko@...com>
Subject: Re: [PATCH] RTC: rtc-twl: Convert to module_platform_driver() and
 relocate reg_map init

Hi,

On 2013-04-16 10:44, Peter Ujfalusi wrote:
> Convert the driver to use module_platform_driver() to register the platform
> driver and relocate the rtc_reg_map initialization to platform driver's
> probe function.
> In this way we can make sure that the twl-core has been already probed since
> the core driver will create the device at the end of it's probe function.
> 
> Reported-by: Christoph Fritz <chf.fritz@...glemail.com>
> Signed-off-by: Peter Ujfalusi <peter.ujfalusi@...com>

I think there are two distinct things here. The actual fix for the
regmap, and a module_platform_driver cleanup. I would suggest having
them in separate patches.

And even if these are combined, I think the patch subject and
description should talk about fixing the regmap bug. Now it's rather
unclear that an actual bug is being fixed.

 Tomi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/