linux-kernel - Re: [PROBLEM] perf requires python-devel to compile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <516DB548.7010703@gmail.com>
Date:	Tue, 16 Apr 2013 13:32:08 -0700
From:	David Ahern <dsahern@...il.com>
To:	Michael Witten <mfwitten@...il.com>
CC:	Pekka Enberg <penberg@...nel.org>,
	Namhyung Kim <namhyung@...nel.org>,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Ingo Molnar <mingo@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PROBLEM] perf requires python-devel to compile

On 4/16/13 10:08 AM, Michael Witten wrote:
> You should probably disable python support more directly:
>
>    make NO_LIBPYTHON=1

sure, but I should not have to do anything. The intent of the existing 
auto-probing code is to figure out what is installed and build a binary 
with those capabilities. In this case not having python installed causes 
it to blow up.

>
> That being said, this issue was introduced with the following commit:
>
>    31160d7feab786c991780d7f0ce2755a469e0e5e
>
> namely due to:
>
>    ... Also fix an issue where _get_attempt was called with only
>    one argument. This prevented the error message from printing
>    the name of the variable that can be used to fix the problem.
>
> specifically:
>
>    -$(if $($(1)),$(call _ge_attempt,$($(1)),$(1)),$(call _ge_attempt,$(2)))
>    +$(if $($(1)),$(call _ge_attempt,$($(1)),$(1)),$(call _ge_attempt,$(2),$(1)))
>
> The "missing" argument was in fact missing on purpose; it's a signal
> that the error message should be skipped, because the failure was due
> to the default value, not the user-supplied value.
>
> That being said, I think there's room for improvement; for instance,
> the error handling should perhaps not belong there. I will look into
> it presently.

Thanks for the pointer. I'll take a look when I get some time.

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/