linux-kernel - Re: [PATCH 16/28] zoran: Don't print proc_dir

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 16 Apr 2013 18:32:19 -0300
From:	Mauro Carvalho Chehab <mchehab@...hat.com>
To:	David Howells <dhowells@...hat.com>
CC:	linux-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	mjpeg-users@...ts.sourceforge.net, viro@...iv.linux.org.uk,
	linux-media@...r.kernel.org, Hans Verkuil <hverkuil@...all.nl>
Subject: Re: [PATCH 16/28] zoran: Don't print proc_dir_entry data in debug
 [RFC]

Em 16-04-2013 15:26, David Howells escreveu:
> Don't print proc_dir_entry data in debug as we're soon to have no direct
> access to the contents of the PDE.  Print what was put in there instead.

Let me just apply this simple one, as it doesn't depend on the rest of the
patches in this series.

>
> Signed-off-by: David Howells <dhowells@...hat.com>
> cc: mjpeg-users@...ts.sourceforge.net
> cc: linux-media@...r.kernel.org
> ---
>
>   drivers/media/pci/zoran/zoran_procfs.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/pci/zoran/zoran_procfs.c b/drivers/media/pci/zoran/zoran_procfs.c
> index 07a104d..f7ceee0 100644
> --- a/drivers/media/pci/zoran/zoran_procfs.c
> +++ b/drivers/media/pci/zoran/zoran_procfs.c
> @@ -201,7 +201,7 @@ zoran_proc_init (struct zoran *zr)
>   		dprintk(2,
>   			KERN_INFO
>   			"%s: procfs entry /proc/%s allocated. data=%p\n",
> -			ZR_DEVNAME(zr), name, zr->zoran_proc->data);
> +			ZR_DEVNAME(zr), name, zr);

It is just a debug message, so changing it looks fine.

>   	} else {
>   		dprintk(1, KERN_ERR "%s: Unable to initialise /proc/%s\n",
>   			ZR_DEVNAME(zr), name);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/