lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 16 Apr 2013 14:32:52 +0800 From: Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com> To: mtosatti@...hat.com Cc: gleb@...hat.com, avi.kivity@...il.com, linux-kernel@...r.kernel.org, kvm@...r.kernel.org, Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com> Subject: [PATCH v3 14/15] KVM: move srcu_read_lock/srcu_read_unlock to arch-specified code Move srcu_read_lock/srcu_read_unlock in kvm_mmu_notifier_release to kvm_arch_flush_shadow_all since we will hold slot-lock instead of srcu Only ARM, POWERPC and x86 are using mmu-notify and kvm_arch_flush_shadow_all on ARM and POWERPC does nothing, so we only need to modify the code on x86 Signed-off-by: Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com> --- arch/x86/kvm/x86.c | 4 ++++ virt/kvm/kvm_main.c | 3 --- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c index 6e7c85b..d3dd0d5 100644 --- a/arch/x86/kvm/x86.c +++ b/arch/x86/kvm/x86.c @@ -7056,7 +7056,11 @@ void kvm_arch_commit_memory_region(struct kvm *kvm, void kvm_arch_flush_shadow_all(struct kvm *kvm) { + int idx; + + idx = srcu_read_lock(&kvm->srcu); kvm_mmu_zap_all(kvm); + srcu_read_unlock(&kvm->srcu, idx); } void kvm_arch_flush_shadow_memslot(struct kvm *kvm, diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c index acc9f30..f48eef9 100644 --- a/virt/kvm/kvm_main.c +++ b/virt/kvm/kvm_main.c @@ -418,11 +418,8 @@ static void kvm_mmu_notifier_release(struct mmu_notifier *mn, struct mm_struct *mm) { struct kvm *kvm = mmu_notifier_to_kvm(mn); - int idx; - idx = srcu_read_lock(&kvm->srcu); kvm_arch_flush_shadow_all(kvm); - srcu_read_unlock(&kvm->srcu, idx); } static const struct mmu_notifier_ops kvm_mmu_notifier_ops = { -- 1.7.7.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists