linux-kernel - Re: [PATCH] kernel: debug: kdb: strncpy issue, using strlcpy instead of strncpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <516E6EBE.60706@asianux.com>
Date:	Wed, 17 Apr 2013 17:43:26 +0800
From:	Chen Gang <gang.chen@...anux.com>
To:	jason.wessel@...driver.com
CC:	kgdb-bugreport@...ts.sourceforge.net,
	"linux-kernel@...r.kernel.org >> \"linux-kernel@...r.kernel.org\"" 
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] kernel: debug: kdb: strncpy issue, using strlcpy instead
 of strncpy

Hello maintainers:

  please help check this patch, when you have time, thanks.

On 2013年04月07日 19:20, Chen Gang wrote:
> 
>   kdb_prompt_str is NUL terminated string, need always set '\0' at the end.
> 
> Signed-off-by: Chen Gang <gang.chen@...anux.com>
> ---
>  kernel/debug/kdb/kdb_io.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/kernel/debug/kdb/kdb_io.c b/kernel/debug/kdb/kdb_io.c
> index 14ff484..932b436 100644
> --- a/kernel/debug/kdb/kdb_io.c
> +++ b/kernel/debug/kdb/kdb_io.c
> @@ -442,7 +442,7 @@ poll_again:
>  char *kdb_getstr(char *buffer, size_t bufsize, char *prompt)
>  {
>  	if (prompt && kdb_prompt_str != prompt)
> -		strncpy(kdb_prompt_str, prompt, CMD_BUFLEN);
> +		strlcpy(kdb_prompt_str, prompt, CMD_BUFLEN);
>  	kdb_printf(kdb_prompt_str);
>  	kdb_nextline = 1;	/* Prompt and input resets line number */
>  	return kdb_read(buffer, bufsize);
> 


-- 
Chen Gang

Asianux Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/