linux-kernel - Re: BUG: Fn keys not working on EliteBook 8460p after fabf85e3ca15d5b94058f391dac8df870cdd427a

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201304171556.38832@pali>
Date:	Wed, 17 Apr 2013 15:56:37 +0200
From:	Pali Rohár <pali.rohar@...il.com>
To:	Matthew Garrett <matthew.garrett@...ula.com>
Cc:	Kyle Evans <kvans32@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"platform-driver-x86@...r.kernel.org" 
	<platform-driver-x86@...r.kernel.org>
Subject: Re: BUG: Fn keys not working on EliteBook 8460p after fabf85e3ca15d5b94058f391dac8df870cdd427a

On Tuesday 16 April 2013 18:26:26 Matthew Garrett wrote:
> Can you try this patch?
> 
> diff --git a/drivers/platform/x86/hp-wmi.c
> b/drivers/platform/x86/hp-wmi.c
> index 45cacf7..91cc5df 100644
> --- a/drivers/platform/x86/hp-wmi.c
> +++ b/drivers/platform/x86/hp-wmi.c
> @@ -53,6 +53,7 @@
> MODULE_ALIAS("wmi:5FB7F034-2C63-45e9-BE91-3D44E2C707E4");
>  #define HPWMI_ALS_QUERY 0x3
>  #define HPWMI_HARDWARE_QUERY 0x4
>  #define HPWMI_WIRELESS_QUERY 0x5
> +#define HPWMI_BIOS_QUERY 0x8
>  #define HPWMI_HOTKEY_QUERY 0xc
>  #define HPWMI_WIRELESS2_QUERY 0x1b
> 
> @@ -284,6 +285,18 @@ static int hp_wmi_tablet_state(void)
>  	return (state & 0x4) ? 1 : 0;
>  }
> 
> +static int hp_wmi_enable_hotkeys()
> +{
> +	int ret;
> +	int query = 1;
> +
> +	ret = hp_wmi_perform_query(HPWMI_BIOS_QUERY, 1, &query,
> sizeof(query), +				   0);
> +	if (ret)
> +		return -EINVAL;
> +	return 0;
> +}
> +
>  static int hp_wmi_set_block(void *data, bool blocked)
>  {
>  	enum hp_wmi_radio r = (enum hp_wmi_radio) data;
> @@ -925,9 +938,7 @@ static int __init hp_wmi_init(void)
>  		err = hp_wmi_input_setup();
>  		if (err)
>  			return err;
> -
> -		//Enable magic for hotkeys that run on the SMBus
> -		ec_write(0xe6,0x6e);
> +		hp_wmi_enable_hotkeys();
>  	}
> 
>  	if (bios_capable) {

Hello,
I tested above patch and it fixing my problem. Now Fn keys working 
again on my HP EliteBook 8460p.

-- 
Pali Rohár
pali.rohar@...il.com

Download attachment "signature.asc " of type "application/pgp-signature" (199 bytes)