linux-kernel - Re: [PATCH] usb: storage: Add usb_stor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1304171012270.1623-100000@iolanthe.rowland.org>
Date:	Wed, 17 Apr 2013 10:14:43 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Joe Perches <joe@...ches.com>
cc:	Matthew Dharm <mdharm-usb@...-eyed-alien.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb <linux-usb@...r.kernel.org>,
	usb-storage <usb-storage@...ts.one-eyed-alien.net>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: storage: Add usb_stor_dbg, reduce object size

On Tue, 16 Apr 2013, Joe Perches wrote:

> Reduce the size of the objects by consolidating
> the duplicated USB_STORAGE into a single function.
> 
> Add function usb_stor_dbg to emit debugging messages.
> Always validate the format and arguments.
> Reduce the number of uses of CONFIG_USB_STORAGE_DEBUG.
> 
> Reduces size of objects ~7KB when CONFIG_USB_STORAGE_DEBUG
> is set.
> 
> $ size drivers/usb/storage/built-in.o*
>    text	   data	    bss	    dec	    hex	filename
>  140133	  55296	  70312	 265741	  40e0d	drivers/usb/storage/built-in.o.new
>  147494	  55248	  70296	 273038	  42a8e	drivers/usb/storage/built-in.o.old
> 
> Signed-off-by: Joe Perches <joe@...ches.com>

Is there any reasonable way to change this so that US_DEBUGP gets
converted to a dev_dbg call instead of a printk call?  Not including
the device identifier in the output can be a real problem if there are
multiple mass-storage devices in the system.

Alan Stern


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/