linux-kernel - Re: [PATCH] usb: storage: Add usb_stor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1304171105360.1623-100000@iolanthe.rowland.org>
Date:	Wed, 17 Apr 2013 11:06:28 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Joe Perches <joe@...ches.com>
cc:	Matthew Dharm <mdharm-usb@...-eyed-alien.net>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb <linux-usb@...r.kernel.org>,
	usb-storage <usb-storage@...ts.one-eyed-alien.net>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: storage: Add usb_stor_dbg, reduce object size

On Wed, 17 Apr 2013, Joe Perches wrote:

> On Wed, 2013-04-17 at 10:14 -0400, Alan Stern wrote:
> > On Tue, 16 Apr 2013, Joe Perches wrote:
> > > Reduce the size of the objects by consolidating
> > > the duplicated USB_STORAGE into a single function.
> []
> > Is there any reasonable way to change this so that US_DEBUGP gets
> > converted to a dev_dbg call instead of a printk call?  Not including
> > the device identifier in the output can be a real problem if there are
> > multiple mass-storage devices in the system.
> 
> No.
> 
> There's no standardized name of a struct device *.
> struct us_data *us exists for most of them but not
> all.  Some have a struct isd_200 *info available,
> other don't have a struct device * at all.
> 
> Some or all US_DEBUGP calls would have to change
> form.
> 
> Perhaps a good patch would be to convert US_DEBUGP
> calls where a struct us_data * is available to
> to us_stor_dbg(struct us_data *, const char *fmt, ...)

That would be an excellent start.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/