linux-kernel - Re: [PATCH] spi: spi-omap2-mcspi.c: Add dts for slave device configuration.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130417151124.GY13687@opensource.wolfsonmicro.com>
Date:	Wed, 17 Apr 2013 16:11:24 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Matthias Brugger <matthias.bgg@...il.com>
Cc:	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>,
	Rob Landley <rob@...dley.net>, Daniel Mack <zonque@...il.com>,
	Enric Balletbo Serra <eballetbo@...il.com>,
	Javier Martinez Canillas <martinez.javier@...il.com>,
	devicetree-discuss@...ts.ozlabs.org, linux-doc@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	spi-devel-general@...ts.sourceforge.net,
	linux-omap@...r.kernel.org, ezequiel.garcia@...e-electrons.com
Subject: Re: [PATCH] spi: spi-omap2-mcspi.c: Add dts for slave device
 configuration.

On Tue, Mar 26, 2013 at 12:00:15AM +0100, Matthias Brugger wrote:

> +- The spi slave nodes can provide the following information which is used
> +  by the spi controller.

> +- ti,spi-cs-per-word: Set chipselect to be toggled on every word send.

Why is this part of the DT binding for the SPI controller?  Surely if
the devices attached to the SPI bus want to configure this they should
be setting things up appropriately in the transfers?  There might be
devices that both want and do not want this on the same bus for example,
and this isn't something that should depend on controller support.

> +- ti,spi-turbo-mode: Set turbo mode for this device.

> +		controller-data {
> +			ti,spi-cs-per-word = <1>;
> +			ti,spi-turbo-mode = <0>;

Better to use a boolean property here - check with of_find_property() to
see if the property is defined at all rather than using a value.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)