linux-kernel - Re: [PATCH v2] HID: appleir: add support for Apple ir devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <516EC8C9.8040000@redhat.com>
Date:	Wed, 17 Apr 2013 18:07:37 +0200
From:	Benjamin Tissoires <benjamin.tissoires@...hat.com>
To:	Oliver Neukum <oneukum@...e.de>
CC:	Jiri Kosina <jkosina@...e.cz>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Benjamin Tissoires <benjamin.tissoires@...il.com>,
	Bastien Nocera <hadess@...ess.net>,
	Fabien <fabien.andre@...il.com>, Jarod Wilson <jarod@...hat.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] HID: appleir: add support for Apple ir devices

On 04/17/2013 12:30 PM, Oliver Neukum wrote:
> On Wednesday 17 April 2013 11:03:09 Benjamin Tissoires wrote:
> 
>> +static void appleir_remove(struct hid_device *hid)
>> +{
>> +       struct appleir *appleir = hid_get_drvdata(hid);
>> +       del_timer_sync(&appleir->key_up_timer);
>> +       hid_hw_stop(hid);
>> +       kfree(appleir);
>> +}
> 
> Hi,
> 
> this looks like a race condition. If you get input between
> del_timer_sync() and hid_hw_stop() the timer may be restarted.
> You need to stop the hw first.
> 

ouch. Thanks for spotting this.
Will send a v3 soon.

Cheers,
Benjamin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/