linux-kernel - Re: PCI: Remove "extern" from function declarations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130418092444.a4d64d8a9b5f700ba2aae779@canb.auug.org.au>
Date:	Thu, 18 Apr 2013 09:24:44 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Bjorn Helgaas <bhelgaas@...gle.com>
Cc:	linux-pci@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: PCI: Remove "extern" from function declarations

Hi Bjorn,

I just noticed this commit (f39d5b72913e "PCI: Remove "extern" from
function declarations") in the pci next branch.  Just wondering why you
would do such a thing.  It is a lot of churn in quite a few header files
and (in my opinion) goes the wrong way anyway.

It may not actually make any difference to the compiler for functions, but
for variables, it does.   A variable declared in a header file without
"extern" will effectively define it in every compilation that includes
the header file, one with "extern" will only produce references.

So, since, the global variables really should have the "extern", the
functions are now inconsistent with that.

It also means that when someone copies a function declaration to make a
"static inline" stub, the "extern" is a big hint for them to remember to
make the stub "static" - I have seen several occasions when this was not
done and that causes compilation failures (but usually only in the
configuration that the author did not bother to test).
-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped