linux-kernel - regulator: tps80031: question about LDO2 TRACK_MODE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1366169084.10398.4.camel@phoenix>
Date:	Wed, 17 Apr 2013 11:24:44 +0800
From:	Axel Lin <axel.lin@...ics.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	Laxman Dewangan <ldewangan@...dia.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	linux-kernel@...r.kernel.org
Subject: regulator: tps80031: question about LDO2 TRACK_MODE_ENABLE of
 TPS80031 or TPS80032-ES1.0

hi Laxman,

Currently we have below code in tps80031_ldo_set_voltage_sel():

        /* Check for valid setting for TPS80031 or TPS80032-ES1.0 */
        if ((ri->rinfo->desc.id == TPS80031_REGULATOR_LDO2) &&
                        (ri->device_flags & TRACK_MODE_ENABLE)) {
                unsigned nvsel = (sel) & 0x1F;
                if (((tps80031_get_chip_info(parent) == TPS80031) ||
                        ((tps80031_get_chip_info(parent) == TPS80032) &&
                        (tps80031_get_pmu_version(parent) == 0x0))) &&
                        ((nvsel == 0x0) || (nvsel >= 0x19 && nvsel <= 0x1F))) {
                                dev_err(ri->dev,
                                        "Invalid sel %d in track mode LDO2\n",
                                        nvsel);
                                return -EINVAL;
                }
        }

However, list_voltage() still show these invalid selectors have supported voltage.
Besides, having the code "nvsel = (sel) & 0x1F" looks a bit odd, because currently
n_voltages is set to 57 when TRACK_MODE_ENABLE is set.

I'm wondering if below comment is still true for LDO2 TRACK_MODE_ENABLE of
"TPS80031/TPS80032-ES1.0"?

/* TRACK mode the ldo2 varies from 600mV to 1300mV */

What is the register value && voltage mapping for LDO2 TRACK_MODE_ENABLE of
TPS80031 or TPS80032-ES1.0?

Regards,
Axel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/