lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 18 Apr 2013 11:01:37 +0200 From: Nicolas Ferre <nicolas.ferre@...el.com> To: <dgilbert@...erlog.com> CC: <linux-arm-kernel@...ts.infradead.org>, <jhovold@...il.com>, <robertcnelson@...il.com>, Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>, Ludovic Desroches <ludovic.desroches@...el.com>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v3] ARM: at91: add Acme Systems Aria G25 board On 04/04/2013 07:03 PM, Douglas Gilbert : > On 13-04-04 11:42 AM, Nicolas Ferre wrote: >> From: Douglas Gilbert <dgilbert@...erlog.com> >> >> Signed-off-by: Douglas Gilbert <dgilbert@...erlog.com> >> Signed-off-by: Nicolas Ferre <nicolas.ferre@...el.com> >> --- >> Hi all, >> >> Here is the third revision of this patch. I plan to include it in a >> pull-request real-soon-now! >> >> v3: - move to "at91-" prefix for .dts[i] files >> - remove the rtc activation code because of the ongoing discussions >> about this IP and its DT binding. >> > > Nicolas, > It's a pity that the rtc activation code is removed. > At worst: > rtc@...ffeb0 { > status = "okay"; > }; I try to re-enalbe it when the at91sam9x5.dtsi exposes a compatibility sting != at91rm9200-rtc will soon appear on mailing-list. > does nothing. Also it is unlikely to be changed by any > movement on the rtc-at91rm9200 front. > > > The lack of use of uart1 is for my own, private reasons. > I think it would be more generally useful to show uart1's > definition and disable it as shown in the attached patch > fragment. Well, if uart1 is available on Aria board, I should enable it! If you do not want it on your own design, you must modify the .dts yourself. So I plan to have an "okay" status on it (and move the definition itself to the generic .dtsi). > I also note that my date line was removed. I like dates, > so when I add comments like "the i2c-at91 driver is broken > for the SAM9G20 ** and use the i2c-gpio driver instead" then > this is not taken as an eternal truth. Yep, I see, but I try to cleanup the patch as much as I can. If you want it untouched, provide me a standard formated patch. > It worked in the > past and hopefully it will work again in the future. > > While on the subject of I2C, I'm getting tired of seeing > this oft-copied line: > i2c-gpio,delay-us = <2>; /* ~100 kHz */ > > It is the clock half period in microseconds and for the 100 kHz > (standard) I2C clock speed, it should be 5. Due to rounding > (up) that gives a measured clock speed of around 88 kHz on > my equipment. Crappy I2C devices *** seem to cope better > with 12% below the standard clock frequency than 80% above > it. Makes sense: I keep it in mind. In parallel, it can be interesting if you can send me a patch with all these mistakes corrected ;-) Bye, -- Nicolas Ferre -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists