linux-kernel - Re: [RFC PATCH 0/2] sched: move content out of core files for load average

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1366283681.19383.5.camel@laptop>
Date:	Thu, 18 Apr 2013 13:14:41 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Frederic Weisbecker <fweisbec@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 0/2] sched: move content out of core files for load
 average

On Mon, 2013-04-15 at 11:33 +0200, Ingo Molnar wrote:
> * Paul Gortmaker <paul.gortmaker@...driver.com> wrote:
> 
> > Recent activity has had a focus on moving functionally related blocks of stuff 
> > out of sched/core.c into stand-alone files.  The code relating to load average 
> > calculations has grown significantly enough recently to warrant placing it in a 
> > separate file.
> > 
> > Here we do that, and in doing so, we shed ~20k of code from sched/core.c (~10%).
> > 
> > A couple small static functions in the core sched.h header were also localized 
> > to their singular user in sched/fair.c at the same time, with the goal to also 
> > reduce the amount of "broadcast" content in that sched.h file.
> 
> Nice!
> 
> Peter, is this (and the naming of the new file) fine with you too?

Yes and no.. that is I do like the change, but I don't like the
filename. We have _waaaay_ too many different things we call load_avg.

That said, I'm having a somewhat hard time coming up with a coherent
alternative :/



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/