linux-kernel - Re: [patch] x86, kvm: fix build failure with CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1304171707090.24494@chino.kir.corp.google.com>
Date:	Wed, 17 Apr 2013 17:09:19 -0700 (PDT)
From:	David Rientjes <rientjes@...gle.com>
To:	Randy Dunlap <rdunlap@...radead.org>,
	Yang Zhang <yang.z.zhang@...el.com>
cc:	Marcelo Tosatti <mtosatti@...hat.com>,
	Gleb Natapov <gleb@...hat.com>,
	Stephen Rothwell <sfr@...b.auug.org.au>, x86@...nel.org,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	KVM <kvm@...r.kernel.org>
Subject: Re: [patch] x86, kvm: fix build failure with CONFIG_SMP disabled

On Wed, 17 Apr 2013, Randy Dunlap wrote:

> On 04/17/13 16:12, David Rientjes wrote:
> > The build fails when CONFIG_SMP is disabled:
> > 
> > 	arch/x86/kvm/vmx.c: In function 'vmx_deliver_posted_interrupt':
> > 	arch/x86/kvm/vmx.c:3950:3: error: 'apic' undeclared (first use in this function)
> > 
> > Fix it by including the necessary header.
> 
> Sorry, i386 build still fails with the same error message plus this one:
> 
> ERROR: "apic" [arch/x86/kvm/kvm-intel.ko] undefined!
> 

Ahh, that's because you don't have CONFIG_X86_LOCAL_APIC as you already 
mentioned.  So it looks like this error can manifest in two different ways 
and we got different reports.

This failure came from "KVM: VMX: Add the deliver posted interrupt 
algorithm", so adding Yang to the cc to specify the dependency this has on 
apic and how it can be protected without CONFIG_X86_LOCAL_APIC on i386.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/