linux-kernel - Re: [PATCH 1/4] mfd: Kontron PLD mfd driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1366303337.2119.22.camel@joe-AO722>
Date:	Thu, 18 Apr 2013 09:42:17 -0700
From:	Joe Perches <joe@...ches.com>
To:	Guenter Roeck <linux@...ck-us.net>
Cc:	Thomas Gleixner <tglx@...utronix.de>,
	Kevin Strasser <kevin.strasser@...ux.intel.com>,
	linux-kernel@...r.kernel.org,
	Michael Brunner <michael.brunner@...tron.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Ben Dooks <ben-linux@...ff.org>, linux-i2c@...r.kernel.org,
	Grant Likely <grant.likely@...retlab.ca>,
	Linus Walleij <linus.walleij@...aro.org>,
	Wim Van Sebroeck <wim@...ana.be>,
	linux-watchdog@...r.kernel.org,
	Darren Hart <dvhart@...ux.intel.com>,
	Michael Brunner <mibru@....de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 1/4] mfd: Kontron PLD mfd driver

On Thu, 2013-04-18 at 06:35 -0700, Guenter Roeck wrote:
> On Wed, Apr 17, 2013 at 09:40:53PM -0700, Joe Perches wrote:
> > On Wed, 2013-04-17 at 21:19 -0700, Guenter Roeck wrote:
> > > On Sat, Apr 13, 2013 at 10:38:07PM +0200, Thomas Gleixner wrote:
> > > > > + return kempld_read8(pld, index) | kempld_read8(pld, index+1) << 8;
> > > >                                                         index + 1)
> > > > Please
> > > Wondering .... why does checkpatch not report those ?
> > 
> > because checkpatch doesn't care about spacing around
> > arithmetic as long as it's consistent.
> > 
> > Documentation/CodingStyle doesn't say anything about
> > it either.
> > 
> Hi Joe,
> 
> "Use one space around (on each side of) most binary and ternary operators"
> 
> doesn't apply, then ? When does it apply ? I always thought it would apply
> to cases such as the above.

There's a _lot_ of code that doesn't follow the
"single space around binary operators" style,
it's contentious, and was determined when Andy
did the original checkpatch implementation to not
be a valuable addition or worth the complaint pain.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/