| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20130418222625.GZ8798@zurbaran> Date: Fri, 19 Apr 2013 00:26:25 +0200 From: Samuel Ortiz <sameo@...ux.intel.com> To: Andrey Smirnov <andrew.smirnov@...il.com> Cc: mchehab@...hat.com, hverkuil@...all.nl, linux-media@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH 09/12] v4l2: Add a V4L2 driver for SI476X MFD Hi Andrey, On Thu, Apr 18, 2013 at 09:58:35AM -0700, Andrey Smirnov wrote: > diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig > index ead9928..170460d 100644 > --- a/drivers/media/radio/Kconfig > +++ b/drivers/media/radio/Kconfig > @@ -18,6 +18,23 @@ config RADIO_SI470X > > source "drivers/media/radio/si470x/Kconfig" > > +config RADIO_SI476X > + tristate "Silicon Laboratories Si476x I2C FM Radio" > + depends on I2C && VIDEO_V4L2 > + select MFD_CORE > + select MFD_SI476X_CORE This is wrong. You want depends on MFD_SI476X_CORE, you should not select a symbol that has other dependencies. It also would allow us to carry the v4l2/media parts of your patchset independently from the MFD ones as the radio driver will not be buildable on a tree where the MFD part is not present. We'll try to figure something out with Mauro. Cheers, Samuel. -- Intel Open Source Technology Centre http://oss.intel.com/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists